Add type validation to factory calls #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
add_type_validation_to_factory_calls
branch
2 times, most recently
from
64fbe0a
to
00aeaa8
Compare
mvorisek
force-pushed
the
add_type_validation_to_factory_calls
branch
from
00aeaa8
to
d0359a9
Compare
mvorisek
force-pushed
the
add_type_validation_to_factory_calls
branch
from
d0359a9
to
f720bb8
Compare
mvorisek
force-pushed
the
add_type_validation_to_factory_calls
branch
2 times, most recently
from
de6be7a
to
157d6a9
Compare
mvorisek
changed the title
mvorisek
commented
Aug 25, 2020
| @@ -216,7 +216,7 @@ public function addColumn(?string $name, $columnDecorator = null, $field = null) | |||
|
|
|||
| if ($field === null) { | |||
| // column is not associated with any model field | |||
| $columnDecorator = $this->_addUnchecked($this->factory($columnDecorator, ['table' => $this])); | |||
| $columnDecorator = $this->_addUnchecked(Table\Column::fromSeed($columnDecorator, ['table' => $this])); | |||
There was a problem hiding this comment.
FYI: _addUnchecked already checks type, but this is more like side effect because add does not work and it can change in the future...
mvorisek
force-pushed
the
add_type_validation_to_factory_calls
branch
from
157d6a9
to
7739dcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.