Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strict array seed #1315

Merged
merged 4 commits into from
Jun 25, 2020
Merged

Use strict array seed #1315

merged 4 commits into from
Jun 25, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jun 24, 2020

merge after: atk4/data#639

no functional change, related with atk4/core#249

@georgehristov
Copy link
Collaborator

Why you decided to switch to array only from "class/object or array"?

@mvorisek
Copy link
Member Author

mvorisek commented Jun 25, 2020

to be exact to "object or array" (i.e. the only required change is to wrap class name/string seeds to an array - if something needs to be changed more, it is more or less bug)

  • Because the current design is mixing almost everything and something even the author does not know what to put where.
  • These are hidden bugs
  • As the seeds are not in a normalized form, a lot of code (maybe 10% of all code) preprocess them "somehow working", but:
    • the behaviours is very inconsistent
    • it is not/can not be tested
    • there are hidden bugs (in preprocessing as well in calls)
    • this extra code can not be maintaned

in the future, there the code can be cleaned up and behaviour can be normalized to clear seed definition (see core/Factory methods)

basically, there should be no specific preprocessing except merging seed with some defaults/forced overrides (passive vs. active merge) and then straight factory call

Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another breaking change, but oh well... LGTM

@mvorisek mvorisek merged commit 8cb7485 into develop Jun 25, 2020
@mvorisek mvorisek deleted the strict_array_seed branch June 25, 2020 15:53
@mvorisek mvorisek mentioned this pull request Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants