-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use strict array seed #1315
Use strict array seed #1315
Conversation
d62b366
to
58ebdb0
Compare
49ae582
to
852c371
Compare
Why you decided to switch to array only from "class/object or array"? |
to be exact to "object or array" (i.e. the only required change is to wrap class name/string seeds to an array - if something needs to be changed more, it is more or less bug)
in the future, there the code can be cleaned up and behaviour can be normalized to clear seed definition (see core/Factory methods) basically, there should be no specific preprocessing except merging seed with some defaults/forced overrides (passive vs. active merge) and then straight factory call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another breaking change, but oh well... LGTM
merge after: atk4/data#639
no functional change, related with atk4/core#249