Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Action button icon #1331

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Fix Action button icon #1331

merged 1 commit into from
Jun 29, 2020

Conversation

DarkSide666
Copy link
Member

Button class already takes care of icons so no need to (wrongly) do that again in ActionButtons class.

Consider example:

// create ActionButtons column without title
$column = $this->crud->table->addColumn(null, [ActionButtons::class, 'caption' => '']);

// see 1st parameter - seed for Button class, icon name passed as string
$column->addModal(['icon' => 'key'], 'Change Password', function ($v, $id) {...});

@DarkSide666
Copy link
Member Author

@mvorisek approved in chat with some comments

@DarkSide666 DarkSide666 merged commit b9e2e82 into develop Jun 29, 2020
@DarkSide666 DarkSide666 deleted the fix-action-button-icon branch June 29, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant