Allow upload multiple #1380
Merged
Allow upload multiple #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
commented
Jul 25, 2020
src/Form/Control/Upload.php
Outdated
| $files[] = $_FILES[$k]; | ||
| } | ||
|
|
||
| if (count($files) > 0) { |
There was a problem hiding this comment.
remains for 1 file only like before and the whole control component
mvorisek
commented
Jul 25, 2020
| $img->onUpload(function ($files) use ($form, $img) { | ||
| if ($files === 'error') { | ||
| $img->onUpload(function ($postFile) use ($form, $img) { | ||
| if ($postFile['error'] !== 0) { |
There was a problem hiding this comment.
we pass now in native php FILES format, also if error
mvorisek
force-pushed
the
allow_upload_multiple
branch
2 times, most recently
from
0daeebd
to
87ba48c
Compare
mvorisek
force-pushed
the
allow_upload_multiple
branch
2 times, most recently
from
77feaa9
to
9f5bf52
Compare
mvorisek
force-pushed
the
allow_upload_multiple
branch
from
9f5bf52
to
20e2a28
Compare
georgehristov
approved these changes
Jul 31, 2020
| $fileName = $_POST['f_name'] ?? null; | ||
| $this->cb->set(function () use ($fx, $fileName) { | ||
| $this->addJsAction($fx($fileName)); | ||
| $this->hasUploadCb = true; |
There was a problem hiding this comment.
$this->hasUploadFx ?
But only if we can refactor $this->cb to $this->fx (BC)
To keep all naming consistent
There was a problem hiding this comment.
it is related with Callback, lets fix this in #1377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds support to multiple files to be uploaded, but only uploaded - the Upload control still remains for one file only
original fx signatures remains - now only more files can be passed
marking as BC breaks as no special "error" string param is passed anymore