Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Behat testing - always fail if page contains uncaught exception #1404

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Improve Behat testing - always fail if page contains uncaught exception #1404

merged 1 commit into from
Aug 7, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Aug 7, 2020 •
edited
Loading

some tests test for text but can currently succeed even if exception is displayed

@mvorisek mvorisek added the Tests label Aug 7, 2020
georgehristov
georgehristov approved these changes Aug 7, 2020
View reviewed changes
Copy link
Collaborator

@georgehristov georgehristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mvorisek mvorisek merged commit bb1ce4d into develop Aug 7, 2020
@mvorisek mvorisek deleted the assert_no_exception branch August 7, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehristov georgehristov georgehristov approved these changes

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @georgehristov