Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render full exception details on ModalExecutor error #1412

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Render full exception details on ModalExecutor error #1412

merged 1 commit into from
Aug 17, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Aug 17, 2020 •
edited
Loading

Fix missing info error info

We still want probably fix #1328 as the Modal can still render in uncontrolled/buggy fashion, very dangerous to existing data as the modal can end up half initialized

@mvorisek mvorisek added the RTM label Aug 17, 2020
georgehristov
georgehristov approved these changes Aug 17, 2020
View reviewed changes
Copy link
Collaborator

@georgehristov georgehristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mvorisek mvorisek merged commit 937cc0a into develop Aug 17, 2020
@mvorisek mvorisek deleted the modal_ex_error_details branch August 17, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehristov georgehristov georgehristov approved these changes

@DarkSide666 DarkSide666 Awaiting requested review from DarkSide666

@ibelar ibelar Awaiting requested review from ibelar

Assignees
No one assigned
Labels
RTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @georgehristov