Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Upload control URL args #1417

Merged
merged 8 commits into from
Aug 19, 2020
Merged

Rename Upload control URL args #1417

merged 8 commits into from
Aug 19, 2020

Conversation

mvorisek
Copy link
Member

No description provided.

@mvorisek mvorisek marked this pull request as draft August 19, 2020 17:26
@mvorisek mvorisek marked this pull request as ready for review August 19, 2020 17:41
georgehristov
georgehristov approved these changes Aug 19, 2020
View reviewed changes
Copy link
Collaborator

@georgehristov georgehristov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is this only for clarity or there is any functionality change?

@mvorisek
Copy link
Member Author

mvorisek commented Aug 19, 2020 •
edited
Loading

Is this only for clarity or there is any functionality change?

clarity/cosmetic/less URL args conflicts (previusly one arg named "action") only

@mvorisek mvorisek merged commit 08f0ede into develop Aug 19, 2020
@mvorisek mvorisek deleted the upload_fname branch August 19, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehristov georgehristov georgehristov approved these changes

@ibelar ibelar Awaiting requested review from ibelar

@DarkSide666 DarkSide666 Awaiting requested review from DarkSide666

Assignees
No one assigned
Labels
BC-break enhancement 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @georgehristov