Fix JS bundle URL escape #1465
Merged
Fix JS bundle URL escape #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
commented
Oct 1, 2020
| @@ -61,7 +61,7 @@ | |||
| // ****** CREATING CUSTOM VUE USING EXTERNAL COMPONENT ***************************** | |||
| \atk4\ui\Header::addTo($app, ['External Component', 'subHeader' => 'Creating component using an external component definition.']); | |||
|
|
|||
| $app->requireJs('https://unpkg.com/vue-clock2@1.1.5/dist/vue-clock.min'); | |||
| $app->requireJs('https://unpkg.com/vue-clock2@1.1.5/dist/vue-clock.min.js'); | |||
There was a problem hiding this comment.
just prevent unneeded redirect...
mvorisek
commented
Oct 1, 2020
src/App.php
Outdated
| @@ -465,7 +465,7 @@ public function initIncludes() | |||
| $this->requireCss($this->cdn['atk'] . '/agileui.css'); | |||
|
|
|||
| // Set js bundle dynamic loading path. | |||
| $this->html->template->trySet('PublicPath', $this->cdn['atk']); | |||
| $this->html->template->trySet('InitJsBundle', (new JsExpression('window.__atkBundlePublicPath=[]', [$this->cdn['atk']]))->jsRender(), false); | |||
There was a problem hiding this comment.
jsRender can not close script tag, thus 100% safe to not escape by definition
mvorisek
commented
Oct 1, 2020
| * @param array $args | ||
| */ | ||
| public function __construct($template = '', $args = []) | ||
| public function __construct(string $template = '', array $args = []) |
There was a problem hiding this comment.
array tag type is super important - otherwise string can be passed without any warning!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we must escape for JS/JSON, not using HTML