Feature/grid crud improvements #156
Conversation
|
Docs will go through #154 |
src/CRUD.php
Outdated
| @@ -87,7 +87,7 @@ public function setModel(\atk4\data\Model $m, $defaultFields = null) | |||
| $m = parent::setModel($m, $this->fieldsGrid ?: $this->fieldsDefault); | |||
|
|
|||
| if ($this->can('u')) { | |||
| $this->addAction(new Icon('pencil'), new jsModal('Edit', $this->pageEdit, [$this->name=>$this->table->jsRow()->data('id')])); | |||
| $this->addAction(['icon'=>'edit'], new jsModal('Edit', $this->pageEdit, [$this->name=>$this->table->jsRow()->data('id')])); | |||
There was a problem hiding this comment.
can use new Grid->jsRow() method here
There was a problem hiding this comment.
yes, correct. i'll update.
| @@ -21,7 +27,7 @@ public function addAction($button, $callback) | |||
| $this->actions[$name] = $button; | |||
| $button->addClass('b_'.$name); | |||
| $button->addClass('compact'); | |||
| $this->table->on('click', '.b_'.$name, $callback); | |||
| $this->table->on('click', '.b_'.$name, $callback, [$this->table->jsRow()->data('id'), 'confirm'=>'Are you sure?']); | |||
There was a problem hiding this comment.
Maybe we can use new $grid->jsRow() here ?
There was a problem hiding this comment.
hmm this change no longer there......
src/View.php
Outdated
| @@ -886,7 +909,7 @@ public function on($event, $selector = null, $action = null, $defaults = null) | |||
| $this->js(true)->on($event, $action); | |||
| } | |||
|
|
|||
| return $thisAction; | |||
| return new jQuery(); | |||
There was a problem hiding this comment.
really return empty jQuery object?
There was a problem hiding this comment.
that's what $thisAction was :) not that i think i might have forgotten to add it into $actions[].
| if (is_numeric($key)) { | ||
| $key = 'c'.$key; | ||
| } | ||
| $this->args[$key] = $val; |
There was a problem hiding this comment.
this line should be moved into if statement above
There was a problem hiding this comment.
no it's designed like this. We keep key as-is if it's symbolic.
There was a problem hiding this comment.
i probably need some tests for that.
There was a problem hiding this comment.
yes you are right, sorry. I thought there is foreach($this->args as ...) :)
| $response = call_user_func($callback, $chain); | ||
|
|
||
| $values = []; | ||
| foreach ($this->args as $key=>$value) { |
There was a problem hiding this comment.
to avoid Avoid unused local variables such as '$value' warning this line should be:
foreach(array_keys($this->args) as $key) {
There was a problem hiding this comment.
that's more cpu/memory intensive. I prefer to ignore the warning.
| if (is_numeric($key)) { | ||
| $key = 'c'.$key; | ||
| } | ||
| $this->args[$key] = $val; |
There was a problem hiding this comment.
yes you are right, sorry. I thought there is foreach($this->args as ...) :)
Grid is now much nicer!!
Known issues: