-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade atk4/data with strict entity model #1623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
distinguish_model_and_entity
branch
13 times, most recently
from
April 28, 2021 16:14
ab346d8
to
cccf2ad
Compare
mvorisek
force-pushed
the
distinguish_model_and_entity
branch
2 times, most recently
from
April 30, 2021 13:41
33b01d3
to
28ae601
Compare
mvorisek
requested review from
georgehristov,
DarkSide666,
abbadon1334 and
ibelar
April 30, 2021 13:42
mvorisek
force-pushed
the
distinguish_model_and_entity
branch
from
May 3, 2021 07:21
28ae601
to
11818ad
Compare
mvorisek
commented
May 5, 2021
mvorisek
force-pushed
the
distinguish_model_and_entity
branch
3 times, most recently
from
May 5, 2021 09:40
337427a
to
15c6457
Compare
ibelar
reviewed
May 5, 2021
mvorisek
force-pushed
the
distinguish_model_and_entity
branch
3 times, most recently
from
May 5, 2021 18:28
2e25df7
to
d0a4279
Compare
Co-authored-by: Alain Belair <belair.alain@gmail.com>
mvorisek
force-pushed
the
distinguish_model_and_entity
branch
from
May 5, 2021 18:30
d0a4279
to
7c66e0c
Compare
ibelar
reviewed
May 5, 2021
ibelar
approved these changes
May 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related with atk4/data#862