Implement Grid Sorting #163
Conversation
|
Resolve #157 |
|
I'm not sure why coverage drop... |
docs/table.rst
Outdated
| $table->sort_by = 'name'; | ||
| $table->sort_order = 'ascending'; | ||
|
|
||
| This will highlight the |
src/Grid.php
Outdated
| @@ -55,6 +55,12 @@ class Grid extends View | |||
| public $selection = null; | |||
|
|
|||
| /** | |||
| * Table can be sorted by clicking on column headers. This will be automatically enabled | |||
There was a problem hiding this comment.
"Grid can be sorted ..." not Table
| return $this->model = $this->table->setModel($model, $columns); | ||
| $this->model = $this->table->setModel($model, $columns); | ||
|
|
||
| if ($this->sortable === null) { |
There was a problem hiding this comment.
why not simply setting $this->sortable=true as default when we define Grid class?
There was a problem hiding this comment.
we will try and detect capability of a model to set order. E.g. if Array persistence does not support, then this will be disabled. Similar with pagination.
| @@ -83,10 +83,8 @@ public function setAttr($attr, $value, $position = 'body') | |||
| * | |||
There was a problem hiding this comment.
no description of new $attr parameter
| When grid is associated with a model that supports order, it will automatically make itself sortable. You can | ||
| override this behaviour by setting $sortable property to `true` or `false`. | ||
|
|
||
| Additionally you may set list of sortable fields to a sortable property if you wish that your grid would be |
There was a problem hiding this comment.
I don't see how this is implemented - "set list of sortable fields ..."
There was a problem hiding this comment.
you are right it's not, but we will need to have PR into agile data to make it work like this. A to-do before release.
$tag was ignored anyway.
Table will now have controls for displaying sorting (non-interractive) and Grid takes it to the next level by enabling dynamic sorting.
Too bad mouse is invisible...