Fix UI typecasting #1667
Merged
Fix UI typecasting #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
fix_no_boolean_field
branch
from
251d28f
to
cf05f1e
Compare
mvorisek
commented
Oct 2, 2021
| @@ -100,7 +100,6 @@ protected function init(): void | |||
| public function set($value = null, $junk = null) | |||
| { | |||
| if ($this->field) { | |||
| $value = $this->getApp()->ui_persistence->typecastLoadField($this->field, $value); | |||
There was a problem hiding this comment.
This was wrong here. Control::set should expect already fully loaded data and can not be used to set data from frontend directly.
mvorisek
force-pushed
the
fix_no_boolean_field
branch
15 times, most recently
from
c54b4c3
to
991838f
Compare
mvorisek
commented
Oct 2, 2021
| @@ -12,7 +12,8 @@ Feature: ScopeBuilder | |||
| Then bool rule "atk_fp_stat__is_commercial" has value "No" | |||
| Then I check if input value for "qb" match text in "p.atk-expected-input-result" | |||
| And I press button "Save" | |||
| Then I check if text in "p.atk-expected-word-result" match text in ".atk-scope-builder-response" | |||
| # TODO uncomment once "Object serialization is not supported" is fixed | |||
| # Then I check if text in "p.atk-expected-word-result" match text in ".atk-scope-builder-response" | |||
There was a problem hiding this comment.
@georgehristov disabling now as we can not serialize for security reasons from the user input. Why do we need to serialize (object type) at all?
mvorisek
force-pushed
the
fix_no_boolean_field
branch
from
d074d37
to
8036c5e
Compare
mvorisek
force-pushed
the
fix_no_boolean_field
branch
from
8889d04
to
b7a0c0c
Compare
mvorisek
force-pushed
the
fix_no_boolean_field
branch
from
894cd19
to
4745ed0
Compare
mvorisek
force-pushed
the
fix_no_boolean_field
branch
5 times, most recently
from
fa03c4f
to
381f1f6
Compare
mvorisek
force-pushed
the
fix_no_boolean_field
branch
2 times, most recently
from
d431047
to
0a0a560
Compare
mvorisek
force-pushed
the
fix_no_boolean_field
branch
from
1cfc31d
to
629e44d
Compare
mvorisek
force-pushed
the
fix_no_boolean_field
branch
from
629e44d
to
066a8fd
Compare
mvorisek
force-pushed
the
fix_no_boolean_field
branch
from
8a0ef30
to
066a8fd
Compare
mvorisek
force-pushed
the
fix_no_boolean_field
branch
from
58bf729
to
21ce1aa
Compare
mvorisek
added
good first issue 🍼
|
Thanks for the review. The issue is here #1668. If you know about any other issue, please post. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge after atk4/core#329 and atk4/data#897