-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all memory leaks #1672
Merged
Merged
Fix all memory leaks #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
no_mem_leaks
branch
8 times, most recently
from
October 5, 2021 23:47
2720a30
to
9aba083
Compare
Closed
mvorisek
force-pushed
the
no_mem_leaks
branch
8 times, most recently
from
October 6, 2021 16:31
d398b10
to
7061b91
Compare
mvorisek
force-pushed
the
no_mem_leaks
branch
2 times, most recently
from
October 6, 2021 16:52
b96303d
to
607bf72
Compare
I verified 1600 iterations of unit tests:
the one failure is leaky experiment correctly detected. |
DarkSide666
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1669
All tests must be able to run 1 000 000 times without any memory increase 😄
The following usecases are leaky by design:
minimal leak per iteration, leaks when the array is resized (4x, 8x, 16x, ...)
https://3v4l.org/JAMjY
leaks when php resizes class table (also in multiple of 2, but as many classes are normally already present, takes much more iterations to detect)
https://3v4l.org/jrqso (demo should include the code below in a look and the results depends if opcache is enabled)