Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Behat stability #1684

Merged
merged 5 commits into from
Oct 21, 2021
Merged

Fix Behat stability #1684

merged 5 commits into from
Oct 21, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Oct 21, 2021 •
edited
Loading

fixes:

  Scenario:                                                      # tests-behat/callback.feature:12
    Given I am on "_unit-test/callback_2.php"                    # Behat\MinkExtension\Context\MinkContext::visit()
    Then I press button "Load1"                                  # Atk4\Ui\Behat\Context::iPressButton()
    Then I should see "Loader-1"                                 # Behat\MinkExtension\Context\MinkContext::assertPageContainsText()
    Then I press button "Load2"                                  # Atk4\Ui\Behat\Context::iPressButton()
    Then I should see "Loader-2"                                 # Behat\MinkExtension\Context\MinkContext::assertPageContainsText()
    Then I should see "Loader-3"                                 # Behat\MinkExtension\Context\MinkContext::assertPageContainsText()
    Then I click paginator page "2"                              # Atk4\Ui\Behat\Context::iClickPaginatorPage()
    Then I click first element using class ".ui.atk-test.button" # Atk4\Ui\Behat\Context::iClickFirstElementUsingClass()
    Then Modal is open with text "Edit Country"                  # Atk4\Ui\Behat\Context::modalIsOpenWithText()
      Exception: Could not get element in page using this selector: .modal.transition.visible.active.front in src/Behat/Context.php:140

image

@mvorisek mvorisek force-pushed the fix_behat_stability branch 5 times, most recently from 3003bb6 to 4f3880a Compare October 21, 2021 17:33
@mvorisek mvorisek marked this pull request as ready for review October 21, 2021 18:03
@mvorisek mvorisek requested a review from ibelar October 21, 2021 18:03
@mvorisek mvorisek force-pushed the fix_behat_stability branch 4 times, most recently from e0c7259 to 2f75b33 Compare October 21, 2021 19:31
@mvorisek mvorisek added the RTM label Oct 21, 2021
DarkSide666
DarkSide666 approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me if that helps

@mvorisek mvorisek merged commit c7e1960 into develop Oct 21, 2021
@mvorisek mvorisek deleted the fix_behat_stability branch October 21, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

@ibelar ibelar Awaiting requested review from ibelar

Assignees
No one assigned
Labels
RTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @DarkSide666