Adjust to non-entity Field only #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
13 times, most recently
from
6919f17
to
3be967a
Compare
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
4 times, most recently
from
e2c2508
to
c03a471
Compare
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
from
2141477
to
c72927a
Compare
fix Model remaining non-entity properties
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
from
33a23c4
to
46e7184
Compare
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
from
7dc9e44
to
b47b515
Compare
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
from
49583ff
to
d418e10
Compare
mvorisek
force-pushed
the
stricter_model_vs_entity
branch
from
552c94d
to
f93e35f
Compare
This reverts commit e815581.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related with atk4/data#912 changes
BC break
a)
Form\Control::$fieldrenamed to$entityFieldwith newAtk4\Data\Model\EntityFieldPairtypeb) some atk4/ui methods were simplified (for example to not accept vague string seed), use phpstan with level 6+ on your project to detect the needed changes