Handle late error when exception handler is active #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thumbs up for this one, very sensible. |
abbadon1334
approved these changes
Nov 29, 2021
mvorisek
force-pushed
the
fix_late_error_output_when_already_handling_ex
branch
from
7b7dfe1
to
6246614
Compare
|
Merging, impossible to unit test as error/exception handler cannot be removed easily, as we do not know if the latest handler is the one set from the App - https://www.php.net/manual/en/function.restore-error-handler.php Late errors can be tested with Behat only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
steps to reproduce:
echo 'xx';)test for this should be added before merge