Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix form2.php demo #1711

Merged
merged 11 commits into from
Dec 5, 2021
Merged

Fix form2.php demo #1711

merged 11 commits into from
Dec 5, 2021

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Nov 29, 2021

Fix: #1704

@ibelar ibelar added the RTM label Nov 29, 2021
@mvorisek
Copy link
Member

@ibelar how can this fix #1704 when there is no JS related code fixed?

Javascript Error Syntax error, unrecognized expression: # is something that should never happen as it signals some non-100% quoting somewhere

mvorisek
mvorisek reviewed Nov 29, 2021
View reviewed changes
demos/form/form2.php Outdated Show resolved Hide resolved
@mvorisek mvorisek removed the RTM label Nov 29, 2021
mvorisek
mvorisek reviewed Dec 2, 2021
View reviewed changes
src/Form.php Outdated Show resolved Hide resolved
mvorisek
mvorisek reviewed Dec 2, 2021
View reviewed changes
src/JsCallback.php Outdated Show resolved Hide resolved
@ibelar
Copy link
Contributor Author

ibelar commented Dec 2, 2021

@mvorisek - any idea why all MSSQL test are failing?

@mvorisek
Copy link
Member

mvorisek commented Dec 2, 2021

@mvorisek - any idea why all MSSQL test are failing?

yes, merge the latest develop (standard DBAL DSN is required in GH CI config)

@ibelar
Copy link
Contributor Author

ibelar commented Dec 2, 2021

yes, merge the latest develop (standard DBAL DSN is required in GH CI config)

Ah - thanks

@ibelar ibelar requested a review from mvorisek December 3, 2021 16:50
mvorisek
mvorisek reviewed Dec 3, 2021
View reviewed changes
src/Behat/Context.php Outdated Show resolved Hide resolved
mvorisek
mvorisek reviewed Dec 3, 2021
View reviewed changes
src/Form.php Outdated Show resolved Hide resolved
@mvorisek mvorisek mentioned this pull request Dec 5, 2021
Merged
mvorisek
mvorisek reviewed Dec 5, 2021
View reviewed changes
src/JsCallback.php Outdated Show resolved Hide resolved
@mvorisek mvorisek force-pushed the fix/form2-demo branch 2 times, most recently from 497a318 to 5f08037 Compare December 5, 2021 12:03
@mvorisek mvorisek force-pushed the fix/form2-demo branch 3 times, most recently from eb6befd to 5dabd09 Compare December 5, 2021 12:58
@mvorisek mvorisek merged commit 4055407 into develop Dec 5, 2021
@mvorisek mvorisek deleted the fix/form2-demo branch December 5, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvorisek mvorisek mvorisek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Field names missing in Model->getField, causing corrupt Exception message
2 participants
@ibelar @mvorisek