Fix user action usage /w entity #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
fix_ua_entity
branch
3 times, most recently
from
179c59b
to
e4f18dc
Compare
mvorisek
changed the title
mvorisek
force-pushed
the
fix_ua_entity
branch
from
e4f18dc
to
c303bc1
Compare
mvorisek
force-pushed
the
fix_ua_entity
branch
from
c303bc1
to
44a2ea6
Compare
mvorisek
commented
Dec 30, 2021
| @@ -86,7 +86,7 @@ public static function setupDemoActions(CountryLock $country): void | |||
| [ | |||
| 'caption' => 'Edit ISO3', | |||
| 'description' => function (UserAction $action) { | |||
| return 'Edit ISO3 for country: ' . $action->getEntity()->getTitle(); | |||
| return 'Edit ISO3 for country: ' /* TODO . $action->getEntity()->getTitle()*/; | |||
There was a problem hiding this comment.
originally, (empty) entity was created when it was not set and getEntity() was called
with atk4/data@ec4a51a#diff-5588f8a6d190c5213f436c880d33b4790cf9f58d2e5f04c7b1e64a7301de15a7L228 no entity is automatically created and this was failing, no replacement avaialble, as the usage is wrong
mvorisek
force-pushed
the
fix_ua_entity
branch
from
44a2ea6
to
dec3f88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust for atk4/data#943 changes