Remove View::id prop in favor of NameTrait::name #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
rm_id_view_prop
branch
from
7435a22
to
826917c
Compare
mvorisek
requested review from
ibelar,
abbadon1334,
georgehristov and
DarkSide666
|
Thumbs up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1765
View::idwas basically a copy ofNameTrait::name, but it was not used consistentlyFinal deduplicated name might be not the most intuitive one, but it is given by core trait
NameTrait::nameand is also much more used thanView::idin the current code base. In the future, we might introduce a more intuitive getter for it with stricter global uniqueness check.