Improve App::getTag() #1839
Merged
Improve App::getTag() #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
commented
Aug 29, 2022
mvorisek
force-pushed
the
improve_get_tag_param_type
branch
from
daf69d5
to
197d0ee
Compare
mvorisek
commented
Aug 30, 2022
src/Form.php
Outdated
| { | ||
| $innerFormTags = ['button', 'datalist', 'fieldset', 'input', 'keygen', 'label', 'legend', | ||
| 'meter', 'optgroup', 'option', 'output', 'progress', 'select', 'textarea', ]; | ||
| $innerFormTags = ['button', 'fieldset', 'input', 'output', 'select', 'textarea']; |
There was a problem hiding this comment.
all other removed tags were added wrongly, they have no form nor for attribute
label is non-value tag /w for attribute, removing now, hopefully not needed - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1838
fix too many "form elements" tags introduced in #1275
minor BC break implied by some no longer supported inputs