Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sticky args in URL #185

Merged
merged 2 commits into from
Jun 24, 2017
Merged

Fix sticky args in URL #185

merged 2 commits into from
Jun 24, 2017

Conversation

DarkSide666
Copy link
Member

  • sticky args should be added even if we use current page in URL
  • adds comments and slightly shorten code

@romaninsh
Copy link
Member

Not sure what's "current page" refers to. you mean index?

@romaninsh romaninsh merged commit 459b71b into develop Jun 24, 2017
@romaninsh romaninsh deleted the feature/fix-url branch June 24, 2017 11:57
@DarkSide666
Copy link
Member Author

well, in this case yes - index page is kind of "current" page.
It's when you call url() without specifying another page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romaninsh romaninsh Awaiting requested review from romaninsh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkSide666 @romaninsh