-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/js enhance #189
Merged
Merged
Feature/js enhance #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add function renderJSON when json response is need for ajax request.
Create a new plugin that will create modal window. Also enhance error display on ajax request.
Apply fixes from StyleCI
Now properly close modal. Problem was coming from jquery that was include in final atk4js bundle. Need to change import $ from ‘jquery’ to const $ = require(‘jquery’) for it no to be include in bundle. modal semantic is still include however. Even if set as external in webpack config. need to find out why but does not seem to cause problem.
update webpack configuration and js plugin file so it does not include semantic-ui-modal in final bundle.
Great PR. |
Merge devel again and Travis will pass. |
Merge is done. Thanks! |
This was referenced Jul 4, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changes:
View::renderJSON()
Create a new method in View::renderJSON() that will handle js output in json format.
jsModal
Change jsModal and delegate creation of the modal dialog to a new js plugin createModal.js
reloadView.js
Change was made to this plugin and now use the semantic api method. The main advantage is that all the json response are sent via the api and catch by api.settings.succesTest function. Also allow to eval script code without duplicating it in DOM.
Lib Atk4JS.js
html.html
Refactor $.fn.api.successTest function to handle new json format.
Testing
I have test this new code against all the demos file and did not find any issue.