Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load vue in JS vueService #1896

Closed
wants to merge 1 commit into from
Closed

Lazy load vue in JS vueService #1896

wants to merge 1 commit into from

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Oct 8, 2022

to reduce the main JS file size

@mvorisek mvorisek force-pushed the lazy_load_vue branch 2 times, most recently from acb0a36 to ce2de4a Compare October 8, 2022 13:40
@mvorisek mvorisek changed the title Lazy load vue for JS vueService Lazy load vue in JS vueService Oct 8, 2022
@mvorisek mvorisek force-pushed the lazy_load_vue branch 5 times, most recently from 8ac3678 to a7cd44f Compare October 8, 2022 17:54
@mvorisek mvorisek closed this Oct 8, 2022
@mvorisek mvorisek deleted the lazy_load_vue branch October 8, 2022 21:03
@mvorisek mvorisek restored the lazy_load_vue branch October 9, 2022 13:13
@mvorisek mvorisek reopened this Oct 9, 2022
@mvorisek
Copy link
Member Author

mvorisek commented Oct 9, 2022

this is problematic also for flatpickr and Sortable globals loaded after main JS

we need some solution as currently flatpickr is always loaded - no problem expect the extra download needed for every page

Sortable is added to App only when user - JS is not loaded if component is loaded using AJAX

@mvorisek mvorisek closed this Oct 9, 2022
@mvorisek mvorisek deleted the lazy_load_vue branch October 9, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant