View::js()/on() returns null when JS chain is explicitly given #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
view_js_null_when_explicit
branch
from
cc54753
to
71f1343
Compare
mvorisek
force-pushed
the
view_js_null_when_explicit
branch
from
71f1343
to
607fde5
Compare
mvorisek
changed the title
mvorisek
changed the title
mvorisek
force-pushed
the
view_js_null_when_explicit
branch
2 times, most recently
from
09013bc
to
23bcea7
Compare
mvorisek
force-pushed
the
view_js_null_when_explicit
branch
from
9ac15dd
to
69bcfeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View::js()andView::on()methods newly returnnullwhen JS action is passed explicitly.Previously these methods stored the passed JS action and created & returned another JS chain.
This is not desired as the created JS chain was stored too but very rarely used (and empty JS chains were skipped on render).
updated
demos/javascript/js.phpdemo in this PR shows the rare usage and how to migrate, IMHO the updated code is much more readable