Fix/double spinner #202
Merged
Fix/double spinner #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semantic api call already has it’s own spinner. no need to show it in reloadView, cause it will appear twice. Also add timeout function to our own spinner.
Deleting column in grid.
|
looks ok. Is "eval" now "atkjs" ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Server response property change
Change response object property that hold javascript from eval to atkjs .
Using eval as property name was conflicting when in Wordpress environment causing the javascript
code to be run twice. Once prior to ApiService::onSucces() method and once in ApiService::onSuccess().
JS fix
Deleting CRUD record
Now properly eval code, even in a Wordpress environment.
Double spinner
Remove spinner from reloadView plugin since, semantic api call already load one.
Add timeout to spinner
Add a timeout function to spinner plugin.