Add App::terminate() stream support #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Apr 4, 2023
tests/AppTest.php
Outdated
| @@ -68,4 +70,22 @@ public function testUnexpectedOutputLateError(): void | |||
| ob_end_clean(); | |||
| } | |||
| } | |||
|
|
|||
| /* throws headers already sent exception so not sure how to write this test for stream output | |||
| public function testStreamResponse(): void | |||
There was a problem hiding this comment.
this test should test sending large (10GB+) data with known pattern to test the response is not materialized somewhere
There was a problem hiding this comment.
To be honest I have no idea how to write that. Will have to ask ChatGPT :)
There was a problem hiding this comment.
implemented and tested with 6GB
the main bottleneck seems to be in Guzzle HTTP client - guzzle/guzzle#3115
until improved, let's test the streaming support with 50 MB only
mvorisek
reviewed
Apr 4, 2023
mvorisek
changed the title
mvorisek
reviewed
Apr 4, 2023
mvorisek
force-pushed
the
feature/support-stream-in-terminate
branch
from
298887b
to
fa76c11
Compare
mvorisek
force-pushed
the
feature/support-stream-in-terminate
branch
from
e0493a8
to
6801f94
Compare
mvorisek
force-pushed
the
feature/support-stream-in-terminate
branch
from
29a2bc2
to
65fbd8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.