-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/notify #205
Feature/notify #205
Conversation
error or warning notification was not display when attach to form because semantic-ui css rule is display:none for a ui.error.message (idem for warning)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this!
Once merged, we can make CRUD use them.
Few notes after I reviewed. First it looks like a visual glitch is introduced: Secondly unlike many other components there are no "simple usage". Perhaps something like this: $button->onClick(function() {
return new jsNotify('All went well');
}); We need to decide what is the best positioning for this. Also a few question about the content - can anything be in there? My final note is that the HTML escaping is not working, we should by default escape everything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my other comment.
That UI layouting problem is not only in your branch, I'll have to check why it's like that, do you also see it locally? looks like some element wasn't closed. |
Humm, don't have the layout problem on my side. |
weird, ok, it's off the list anyway. Will have to investigate. |
will do some integration testing but on course for 1.2 |
Notification
notify.js as an AtkPlugin
Add js plugin for creating nice notification.
notify.php
For demonstration purpose in demos.