Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add App::url() method tests #2109

Merged
merged 68 commits into from
Sep 17, 2023
Merged

Add App::url() method tests #2109

merged 68 commits into from
Sep 17, 2023

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Sep 17, 2023 •
edited

extracted from #2095

abbadon1334 and others added 30 commits August 25, 2023 22:34
@abbadon1334
Fix PrettyUrl legitimate path
7fdbbe7
@abbadon1334
Add Unit tests for App::url
ba90e32
@abbadon1334
add default excepted page and extension
f2dd8f3
@abbadon1334
fix 7.4 array merge with keys / spread operator
6713d61
@abbadon1334
Add more test cases for App:url
04720c5
@abbadon1334
Reorganize code
80b8fca
@abbadon1334
Improve converage
27d9cb4
@abbadon1334
Improve App::url tests
67f0594
@abbadon1334
Skip $useRequestUrl=true due to REQUEST_URI
b2810b8
@abbadon1334
Change REQUEST_URI to Psr7 methods
3997714
@abbadon1334
Allow $useRequestUrl=true
4348ff1
@abbadon1334
clean up
e4c3428
@abbadon1334
Improve error message
7895ec9
@abbadon1334
CS Fix
f1fefac
@abbadon1334
Merge branch 'develop' into add_tests_app_url
308cc87
@abbadon1334
Add App::$urlBuildingPage to customize url building page
23a5a6b
@abbadon1334
Comment out App::url failing tests
f3f099f
@abbadon1334
Merge branch 'develop' into fix_pretty_url_legitimate_path
3c36038
@abbadon1334
Avoid change of global var $_SERVER
534cff4
@abbadon1334
Fix missing request in App for Unit tests
a01c3bb
@abbadon1334
Comment out not working tests
62f370b
@abbadon1334
Strong type for $urlBuildingXxx vars
645e0aa
@abbadon1334
Use CreateApp
7022361
@abbadon1334
Remove message from Assert
0a1bd7f
@abbadon1334
Cs Fix
95b7d1e
@abbadon1334
Raise Nyholm/psr7 from 1.4 to 1.6
7bd47a2
@mvorisek
Merge branch 'develop' into add_tests_app_url
d5b4224
@mvorisek
DEBUG REVERT ALL
47d6032
@mvorisek
introduce App::$urlBuildingIndexPage prop
d4a0810
@mvorisek
drop protected App::getRequestUrl() method
89e3efa
@mvorisek mvorisek marked this pull request as ready for review September 17, 2023 13:44
@mvorisek mvorisek merged commit d824a66 into develop Sep 17, 2023
54 of 55 checks passed
@mvorisek mvorisek deleted the add_url_testing branch September 17, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvorisek @abbadon1334