Always assert request URL path starts with '/' #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
no_get_mutate_in_testing
branch
4 times, most recently
from
5c559f7
to
31cd75c
Compare
mvorisek
force-pushed
the
no_get_mutate_in_testing
branch
2 times, most recently
from
35aed49
to
a61cf9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normally, request is created from $_SERVER, $_GET, ... globals (or passed explicitly) and thus this PR should have no effect on developer
fixes TODO in
App::urlApp::$requestshould be readonly, thus checking in the App constructor should be enough