Always reload full executor container #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
modal_outer_reload
branch
2 times, most recently
from
3349947
to
fd17a75
Compare
mvorisek
force-pushed
the
modal_outer_reload
branch
3 times, most recently
from
724645c
to
4081fb2
Compare
mvorisek
force-pushed
the
modal_outer_reload
branch
from
4081fb2
to
0060439
Compare
mvorisek
force-pushed
the
modal_outer_reload
branch
2 times, most recently
from
6e929c2
to
65f779d
Compare
mvorisek
force-pushed
the
modal_outer_reload
branch
from
65f779d
to
a1bbbd4
Compare
mvorisek
force-pushed
the
modal_outer_reload
branch
from
c19ea3b
to
85d1362
Compare
mvorisek
force-pushed
the
modal_outer_reload
branch
3 times, most recently
from
92d04b5
to
894a626
Compare
mvorisek
force-pushed
the
modal_outer_reload
branch
from
894a626
to
a19ec6e
Compare
mvorisek
force-pushed
the
modal_outer_reload
branch
from
4a51658
to
06ef900
Compare
mvorisek
requested review from
romaninsh,
DarkSide666,
ibelar,
abbadon1334,
georgehristov,
mkrecek234 and
PhilippGrashoff
DarkSide666
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
I'm a bit left behind of late progress of ATK and UI in particular so hard to say if all is good here, but on first glance looks OK.
Only thing I would like to add here (or later in some future PR) is as you already said - in the future, it should be solved by a loader added to the triggering element (like button), the triggering element should be probably also disabled until the action is complete
This is quite essential to have especially in cases if modal is slow to load and it should be restricted to call it multiple times in parallel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1928
also improve performance as analysed in #1976 (comment)
the only known negative is no loader before modal/panel is shown, this is expected and in the future, it should be solved by a loader added to the triggering element (like button), the triggering element should be probably also disabled until the action is complete