-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big addColumn, addField and Seed refactor (PART2) #223
Big addColumn, addField and Seed refactor (PART2) #223
Conversation
…refactor-columns-fields
Codecov Report
@@ Coverage Diff @@
## epic/atk-core-refactor #223 +/- ##
===========================================================
- Coverage 39.02% 31.43% -7.6%
Complexity 1053 1053
===========================================================
Files 58 58
Lines 2483 2488 +5
===========================================================
- Hits 969 782 -187
- Misses 1514 1706 +192
Continue to review full report at Codecov.
|
…ture/actually-refactor-columns-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
'password' => 'Password', | ||
'text' => 'Text', | ||
'boolean' => ['Status', 'positive'=>[true], 'negative'=>['false']], | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we have more types ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we?
In this part I've implemented Table::addColumn() as per requirements in #188.
demo/table.php works well now, but other pages still fail. Some additional documentation needed here, but other UI elements will be resolved in PART3.
Approve / Merge #179 before this.