Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big addColumn, addField and Seed refactor (PART2) #223

Merged

Conversation

romaninsh
Copy link
Member

@romaninsh romaninsh commented Sep 10, 2017

In this part I've implemented Table::addColumn() as per requirements in #188.

demo/table.php works well now, but other pages still fail. Some additional documentation needed here, but other UI elements will be resolved in PART3.

Approve / Merge #179 before this.

@romaninsh romaninsh changed the base branch from develop to epic/atk-core-refactor September 11, 2017 12:30
@codecov
Copy link

codecov bot commented Sep 11, 2017

Codecov Report

Merging #223 into epic/atk-core-refactor will decrease coverage by 7.59%.
The diff coverage is 58.53%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##             epic/atk-core-refactor     #223     +/-   ##
===========================================================
- Coverage                     39.02%   31.43%   -7.6%     
  Complexity                     1053     1053             
===========================================================
  Files                            58       58             
  Lines                          2483     2488      +5     
===========================================================
- Hits                            969      782    -187     
- Misses                         1514     1706    +192
Impacted Files Coverage Δ Complexity Δ
src/Table.php 26.66% <58.53%> (-40.71%) 77 <21> (ø)
src/TableColumn/Template.php 0% <0%> (-87.5%) 5% <0%> (ø)
src/TableColumn/Money.php 0% <0%> (-87.5%) 7% <0%> (ø)
src/TableColumn/Delete.php 0% <0%> (-83.34%) 5% <0%> (ø)
src/CallbackLater.php 0% <0%> (-60%) 4% <0%> (ø)
src/TableColumn/Link.php 34.28% <0%> (-57.15%) 20% <0%> (ø)
src/TableColumn/Generic.php 6.52% <0%> (-56.53%) 21% <0%> (ø)
src/jsExpression.php 60.75% <0%> (-16.46%) 36% <0%> (ø)
src/Callback.php 10.71% <0%> (-10.72%) 8% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41cc057...73e14e8. Read the comment docs.

Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

'password' => 'Password',
'text' => 'Text',
'boolean' => ['Status', 'positive'=>[true], 'negative'=>['false']],
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have more types ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we?

@DarkSide666 DarkSide666 merged commit 201cd99 into epic/atk-core-refactor Sep 15, 2017
@romaninsh romaninsh deleted the feature/actually-refactor-columns-fields branch September 18, 2017 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants