Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add triggered #226

Merged
merged 3 commits into from
Oct 8, 2017
Merged

Feature/add triggered #226

merged 3 commits into from
Oct 8, 2017

Conversation

romaninsh
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 18, 2017

Codecov Report

Merging #226 into develop will decrease coverage by 17.73%.
The diff coverage is 33.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop     #226       +/-   ##
==============================================
- Coverage      69.87%   52.13%   -17.74%     
- Complexity       842     1047      +205     
==============================================
  Files             42       57       +15     
  Lines           1852     2482      +630     
==============================================
  Hits            1294     1294               
- Misses           558     1188      +630
Impacted Files Coverage Δ Complexity Δ
src/Button.php 81.81% <ø> (ø) 8 <0> (ø) ⬇️
src/VirtualPage.php 41.02% <0%> (-58.98%) 26 <1> (+1)
src/Callback.php 86.66% <50%> (-6.2%) 10 <4> (+2)
src/Text.php 22.22% <0%> (-77.78%) 4% <0%> (+3%)
src/Persistence/UI.php 37.14% <0%> (-62.86%) 39% <0%> (+17%)
src/Label.php 38.09% <0%> (-61.91%) 8% <0%> (+2%)
src/Menu.php 59.64% <0%> (-40.36%) 21% <0%> (+6%)
src/FormField/Generic.php 66.66% <0%> (-33.34%) 6% <0%> (ø)
src/Message.php 68.42% <0%> (-31.58%) 8% <0%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ddd0bc...47d9a89. Read the comment docs.

@DarkSide666 DarkSide666 self-requested a review September 20, 2017 21:51
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful commit.
Not sure what's going on with code coverage, but who cares :)

@romaninsh romaninsh merged commit f74561a into develop Oct 8, 2017
@romaninsh romaninsh deleted the feature/add-triggered branch October 8, 2017 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants