Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow virtualpage->set() to accept [$obj, $method] #232

Merged
merged 5 commits into from
Oct 13, 2017

Conversation

DarkSide666
Copy link
Member

@DarkSide666 DarkSide666 commented Oct 13, 2017

fixes #231

@codecov
Copy link

codecov bot commented Oct 13, 2017

Codecov Report

Merging #232 into develop will increase coverage by 0.53%.
The diff coverage is 22.22%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #232      +/-   ##
=============================================
+ Coverage      72.96%   73.49%   +0.53%     
+ Complexity      1053     1051       -2     
=============================================
  Files             58       58              
  Lines           2508     2513       +5     
=============================================
+ Hits            1830     1847      +17     
+ Misses           678      666      -12
Impacted Files Coverage Δ Complexity Δ
src/View.php 78.02% <0%> (-0.51%) 128 <0> (ø)
src/VirtualPage.php 78.57% <28.57%> (+37.54%) 24 <0> (-2) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0874638...7eb8eed. Read the comment docs.

@romaninsh romaninsh changed the title Feature/virtual page callback Allow virtualpage->set() to accept [$obj, $method] Oct 13, 2017
@romaninsh romaninsh merged commit 585421a into develop Oct 13, 2017
@romaninsh romaninsh deleted the feature/virtual-page-callback branch October 13, 2017 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

virtual page does not support callable array
2 participants