Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tab url #240

Merged
merged 2 commits into from
Oct 17, 2017
Merged

Fix/tab url #240

merged 2 commits into from
Oct 17, 2017

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Oct 17, 2017

Fix Cursor when hovering on tab.

Tab menu item needs to be define as anchor element instead of div in order for semantic-ui.css to show pointer cursor over tab.

@codecov
Copy link

codecov bot commented Oct 17, 2017

Codecov Report

Merging #240 into develop will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #240      +/-   ##
============================================
+ Coverage      73.57%   73.7%   +0.12%     
  Complexity      1051    1051              
============================================
  Files             58      58              
  Lines           2513    2514       +1     
============================================
+ Hits            1849    1853       +4     
+ Misses           664     661       -3
Impacted Files Coverage Δ Complexity Δ
src/Tabs.php 82.35% <100%> (+0.53%) 9 <0> (ø) ⬇️
src/TableColumn/Status.php 84.37% <0%> (+9.37%) 10% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63f440c...49d4958. Read the comment docs.

@romaninsh romaninsh merged commit 808d5ae into atk4:develop Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants