Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/autocomplete field #245

Merged
merged 29 commits into from
Nov 7, 2017
Merged

Feature/autocomplete field #245

merged 29 commits into from
Nov 7, 2017

Conversation

romaninsh
Copy link
Member

@romaninsh romaninsh commented Oct 22, 2017

Implementation of AutoComplete with a callback. (#243). Simple use:

$model->hasOne('country_id', [new Country(), 'ui'=>['Form'=>'Autocomplete']]);

Auto-complete allows your dropdown to have more entries and only load the ones that match user typing. It allows to search for phrases or even in multiple fields.

Drag a SCREENSHOT here:

p.s. set label "in review" and assign reviewers if PR is complete. Otherwise set "work in progress" label.

ibelar and others added 7 commits October 19, 2017 11:40
Add support for icon and label beside input field.
Icon still has some problem.
…eature/autocomplete-field

# Conflicts:
#	demos/autocomplete.php
#	src/FormField/AutoComplete.php
@atk4 atk4 deleted a comment from codecov bot Nov 2, 2017
@atk4 atk4 deleted a comment from codecov bot Nov 2, 2017
@codecov
Copy link

codecov bot commented Nov 2, 2017

Codecov Report

Merging #245 into develop will increase coverage by 3.1%.
The diff coverage is 52.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop     #245     +/-   ##
============================================
+ Coverage      71.34%   74.45%   +3.1%     
- Complexity      1110     1128     +18     
============================================
  Files             62       63      +1     
  Lines           2729     2791     +62     
============================================
+ Hits            1947     2078    +131     
+ Misses           782      713     -69
Impacted Files Coverage Δ Complexity Δ
src/FormField/CheckBox.php 81.81% <ø> (ø) 6 <0> (?)
src/FormField/Generic.php 91.66% <ø> (ø) 6 <0> (ø) ⬇️
src/DropDown.php 100% <ø> (ø) 2 <0> (?)
src/FormField/TextArea.php 100% <ø> (ø) 4 <0> (?)
src/FormField/DropDown.php 96.66% <ø> (ø) 10 <0> (?)
src/TableColumn/CheckBox.php 93.33% <0%> (ø) 6 <0> (?)
src/FormLayout/Generic.php 90.75% <100%> (+5.04%) 50 <0> (+1) ⬆️
src/FormField/Input.php 98.46% <100%> (+0.07%) 30 <1> (+1) ⬆️
src/Grid.php 80.55% <100%> (ø) 28 <0> (ø) ⬇️
src/View.php 80.95% <100%> (+1.26%) 129 <7> (ø) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82df87...fb9fb37. Read the comment docs.

@romaninsh romaninsh merged commit 9230c62 into develop Nov 7, 2017
@romaninsh romaninsh deleted the feature/autocomplete-field branch November 7, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants