Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/layout to app in docs #248

Merged
merged 3 commits into from
Oct 25, 2017
Merged

Conversation

DarkSide666
Copy link
Member

fixes #247

@codecov
Copy link

codecov bot commented Oct 25, 2017

Codecov Report

Merging #248 into develop will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #248      +/-   ##
=============================================
+ Coverage      73.46%   73.57%   +0.11%     
  Complexity      1067     1067              
=============================================
  Files             59       59              
  Lines           2570     2570              
=============================================
+ Hits            1888     1891       +3     
+ Misses           682      679       -3
Impacted Files Coverage Δ Complexity Δ
src/TableColumn/Status.php 84.37% <0%> (+9.37%) 10% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb905f7...5f0d6bf. Read the comment docs.

@DarkSide666
Copy link
Member Author

there will be some conflicts with #246 to solve

@romaninsh
Copy link
Member

mass replace? :D i wonder just if there are any examples that demonstrate $layout features explicitly, e.g. $layout->addMenu, can you double-check before merging.. Manual review will be too complex anyway.

@romaninsh
Copy link
Member

OK to merge, i'll fix the #246 if needed.

@DarkSide666
Copy link
Member Author

It was not mass replace, but close to that. I manually checked each replace. Of course there is small possibility that i made mistake somewhere, but i also checked demo scripts and they worked fine.
If i remember correctly there was few places which demonstrate specific usage of layout (like addMenu etc.) and these are not changed.

@DarkSide666 DarkSide666 merged commit 1067005 into develop Oct 25, 2017
@DarkSide666 DarkSide666 deleted the feature/layout-to-app-in-docs branch October 25, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In docs - replace $layout with $app.
2 participants