Added Documentation fro jsNotify, Modal and jsModal #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #256 +/- ##
=============================================
+ Coverage 72.77% 73.47% +0.69%
- Complexity 1072 1076 +4
=============================================
Files 60 60
Lines 2586 2590 +4
=============================================
+ Hits 1882 1903 +21
+ Misses 704 687 -17
Continue to review full report at Codecov.
|
ibelar
approved these changes
Nov 1, 2017
DarkSide666
reviewed
Nov 2, 2017
| @@ -47,7 +47,9 @@ | |||
| $basic->addItem('JavaScript Events', ['button2']); | |||
| $basic->addItem('Element Reloading', ['reloading']); | |||
| $basic->addItem('Loader', ['loader']); | |||
| $basic->addItem('Modal Dialogs', ['modal']); | |||
| $basic->addItem('Noifyer', ['notify']); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up examples and new documentation.
Also contain some fixes to core classes, so review carefully ;)