Fix/issue254 255 modal

[ibelar]

Fix issue 254

• Apply loading indicator to modal create either via jsModal or Modal.php
• allow to supply loading indicator label, default to "Loading...", from jsModal or Modal

Enhancement issue 255

• Allow to pass url argument to Modal::show($arg) method.

$app->add(['Button', 'Show'])->on('click', $modal->show(['color'=>'blue']));

Apply some refactoring on passing data to modal

• data is now pass via the $.data() function either for Modal.php or jsModal, thus removing the html data attribute in modal.html template.

Note: Atk4JS need rebuilding.

[codecov]

Codecov Report

Merging #257 into develop will increase coverage by <.01%.
The diff coverage is 81.81%.

@@              Coverage Diff              @@
##             develop     #257      +/-   ##
=============================================
+ Coverage      72.12%   72.13%   +<.01%     
- Complexity      1111     1113       +2     
=============================================
  Files             62       62              
  Lines           2730     2738       +8     
=============================================
+ Hits            1969     1975       +6     
- Misses           761      763       +2

Impacted Files	Coverage Δ	Complexity Δ
src/Modal.php	42.68% <81.81%> (+3.49%)	32 <2> (+2)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c9dc8a...0340e06. Read the comment docs.

[romaninsh]

Is this ready for review?

[romaninsh]

I tried added test, but I'm getting a failure. Maybe I'm not doing it correctly?

[ibelar]

Change the way how arguments are save to modal when using Modal::show($args).

Also remove view tester on second modal since tester will reset Message color on it's last callback because $_Get['color'] is not available when view tester reload.

[romaninsh]

works perfectly now. Will merge now.