Fix/js sse on non supporting browser #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be merged aftter #258 ? |
Better uri assignation; Switch from atkAjaxec to atkReloadView for GET support in reloadView
…upporting-browser
|
@DarkSide666 you'll have to test / review this because I don't have IE. |
Codecov Report
@@ Coverage Diff @@
## develop #259 +/- ##
=============================================
+ Coverage 71.34% 72.12% +0.77%
- Complexity 1110 1111 +1
=============================================
Files 62 62
Lines 2729 2730 +1
=============================================
+ Hits 1947 1969 +22
+ Misses 782 761 -21
Continue to review full report at Codecov.
|
|
@ibelar i had to fix a little, it was broken. can you check if it still OK as a fix? |
|
OK to ignore codecov/patch coverage, because zombiejs cant trigger SSE. |
…r' into fix/jsSse-on-non-supporting-browser
serverEvent.js plugin: - change how url param is pass to server. - add option to display a loader on the element generating the event. jsSSE.php - change how trigger is meet via $_Get[‘event’] param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix jsSse to run callback function on non supporting browser.
On non supporting browser, like IE, the set callback function is never run.
Using this fix, the atkServerEvent.js plugin will fallback with using atkAjaxec.js when this occur, in order for the callback function define in set to be able to run and at least complete.