Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/callback get url #271

Merged
merged 2 commits into from
Nov 19, 2017
Merged

Fix/callback get url #271

merged 2 commits into from
Nov 19, 2017

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Nov 17, 2017

Delegate full control to App:url() method from Callback::getUrl() by passing an extra argument to App::url().

Prior to this, an hosting app did not have full control of url argument creation when using Callback with Form or Callback using POST_trigger property set to true.
By delegating the url creation to App::url() method, now an hosting app will have full control of arguments needed with returning url.

@codecov
Copy link

codecov bot commented Nov 17, 2017

Codecov Report

Merging #271 into develop will decrease coverage by 0.57%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             develop   #271      +/-   ##
===========================================
- Coverage      75.57%    75%   -0.58%     
  Complexity      1131   1131              
===========================================
  Files             63     63              
  Lines           2800   2800              
===========================================
- Hits            2116   2100      -16     
- Misses           684    700      +16
Impacted Files Coverage Δ Complexity Δ
src/Callback.php 96.42% <100%> (-0.24%) 9 <0> (-1)
src/App.php 81.05% <100%> (+0.16%) 94 <17> (+1) ⬆️
src/jsSSE.php 17.54% <0%> (-31.58%) 19% <0%> (ø)
src/TableColumn/Status.php 84.37% <0%> (+6.25%) 10% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab3833...0f6451b. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 17, 2017

Codecov Report

Merging #271 into develop will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #271      +/-   ##
=============================================
+ Coverage      75.57%   75.64%   +0.07%     
  Complexity      1131     1131              
=============================================
  Files             63       63              
  Lines           2800     2800              
=============================================
+ Hits            2116     2118       +2     
+ Misses           684      682       -2
Impacted Files Coverage Δ Complexity Δ
src/Callback.php 96.42% <100%> (-0.24%) 9 <0> (-1)
src/App.php 81.05% <100%> (+0.16%) 94 <17> (+1) ⬆️
src/TableColumn/Status.php 84.37% <0%> (+6.25%) 10% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab3833...0f6451b. Read the comment docs.

Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, will merge.

@romaninsh romaninsh merged commit 693fc27 into develop Nov 19, 2017
@romaninsh romaninsh deleted the fix/Callback-getUrl branch December 26, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants