Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console->set() captures executon info/output. #546

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

romaninsh
Copy link
Member

Minor enhancement adding output to console even if you use set().

Currently runMethod() will substitute app->logger to the console itself and will capture all the info() and warning() raised by objects. If you are using set() no such thing is done.

This PR makes set() work similar to runMethod():

screen shot 2018-08-22 at 14 24 32

@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #546 into develop will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #546      +/-   ##
=============================================
- Coverage       66.7%   66.62%   -0.09%     
- Complexity      1618     1622       +4     
=============================================
  Files             91       91              
  Lines           3875     3880       +5     
=============================================
  Hits            2585     2585              
- Misses          1290     1295       +5
Impacted Files Coverage Δ Complexity Δ
src/Console.php 9.58% <0%> (-0.35%) 62 <0> (+4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eb3ac1...a3eec2e. Read the comment docs.

Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix

@DarkSide666 DarkSide666 merged commit 260ef90 into develop Aug 22, 2018
@DarkSide666 DarkSide666 deleted the feature/console-output-log branch August 22, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants