Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/form section #600

Merged
merged 80 commits into from
Nov 27, 2018
Merged

Feature/form section #600

merged 80 commits into from
Nov 27, 2018

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Nov 21, 2018

Note

Replace previous Feature/Accordion.

This PR add ability to setup a layout section in Form where field can be added to the view.

screen shot 2018-11-20 at 11 50 30 am

screen shot 2018-11-20 at 11 50 38 am

screen shot 2018-11-20 at 11 50 46 am

screen shot 2018-11-20 at 11 50 52 am

@DarkSide666 DarkSide666 self-requested a review November 21, 2018 20:29
Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor changes, please address, then good to merge!

docs/form.rst Outdated Show resolved Hide resolved
docs/form.rst Show resolved Hide resolved
$f->setModel($m, false);

$sub_layout = $f->layout->addSubLayout();
$sub_layout->setModel($m, ['first_name', 'last_name']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can $m be optional here btw?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also what happens if a different model is used here... ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically $m can be optional and then sub-layout could take model from it's parent layout ...

About different model - no idea, ave not tested that :)

docs/form.rst Show resolved Hide resolved
src/Accordion.php Show resolved Hide resolved
@romaninsh romaninsh merged commit 8665818 into develop Nov 27, 2018
@romaninsh romaninsh deleted the feature/form-section branch December 26, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants