Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "confirm" option support for js->on() case #642

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

DarkSide666
Copy link
Member

Now will support 'confirm' option also in this case not only when you use callback.

$btn->on(
    'click',
    [
        new jsReload($installer, ['start' => 1], null, ['stateContext' => '#'.$btn->name]),
        $btn->js()->addClass('disabled'),
    ],
    ['confirm' => 'Are you sure you want to install this add-on?']
);

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #642 into develop will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #642      +/-   ##
=============================================
+ Coverage      69.73%   69.81%   +0.08%     
- Complexity      1852     1853       +1     
=============================================
  Files            100      100              
  Lines           4374     4377       +3     
=============================================
+ Hits            3050     3056       +6     
+ Misses          1324     1321       -3
Impacted Files Coverage Δ Complexity Δ
src/View.php 81.59% <100%> (+0.17%) 141 <0> (+1) ⬆️
src/TableColumn/Status.php 82.35% <0%> (+8.82%) 12% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e40ba...f9e3a60. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #642 into develop will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #642      +/-   ##
=============================================
+ Coverage      69.73%   69.81%   +0.08%     
- Complexity      1852     1853       +1     
=============================================
  Files            100      100              
  Lines           4374     4377       +3     
=============================================
+ Hits            3050     3056       +6     
+ Misses          1324     1321       -3
Impacted Files Coverage Δ Complexity Δ
src/View.php 81.59% <100%> (+0.17%) 141 <0> (+1) ⬆️
src/TableColumn/Status.php 82.35% <0%> (+8.82%) 12% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e40ba...f9e3a60. Read the comment docs.

Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibelar you might also need to look, i wonder if there is a duplicate somewhere..

@PhilippGrashoff
Copy link
Collaborator

fixes #503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants