Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Lister #660

Merged
merged 1 commit into from
Feb 24, 2019
Merged

fix Lister #660

merged 1 commit into from
Feb 24, 2019

Conversation

DarkSide666
Copy link
Member

We need clone here, but it's ok because it's not repeated in a loop.

@codecov
Copy link

codecov bot commented Feb 24, 2019

Codecov Report

Merging #660 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #660      +/-   ##
=============================================
- Coverage      69.82%   69.82%   -0.01%     
  Complexity      1864     1864              
=============================================
  Files            101      101              
  Lines           4395     4394       -1     
=============================================
- Hits            3069     3068       -1     
  Misses          1326     1326
Impacted Files Coverage Δ Complexity Δ
src/Lister.php 69.49% <100%> (-0.51%) 23 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c80f6d...58d0799. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 24, 2019

Codecov Report

Merging #660 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #660      +/-   ##
=============================================
- Coverage      69.82%   69.82%   -0.01%     
  Complexity      1864     1864              
=============================================
  Files            101      101              
  Lines           4395     4394       -1     
=============================================
- Hits            3069     3068       -1     
  Misses          1326     1326
Impacted Files Coverage Δ Complexity Δ
src/Lister.php 69.49% <100%> (-0.51%) 23 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c80f6d...58d0799. Read the comment docs.

@DarkSide666 DarkSide666 merged commit 79337b4 into develop Feb 24, 2019
@DarkSide666 DarkSide666 deleted the DarkSide666-patch-2 branch February 24, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants