-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add definition of defaults for Field Lookup #670
Add definition of defaults for Field Lookup #670
Conversation
add definition of plus button, in place of set "plus" => true and add the default label, "plus" => ['icon'=>'plus','class'=>'green']
Codecov Report
@@ Coverage Diff @@
## develop #670 +/- ##
=============================================
- Coverage 72.75% 72.69% -0.07%
- Complexity 1868 1869 +1
=============================================
Files 102 102
Lines 4416 4416
=============================================
- Hits 3213 3210 -3
- Misses 1203 1206 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #670 +/- ##
=============================================
+ Coverage 72.75% 72.76% +<.01%
- Complexity 1868 1870 +2
=============================================
Files 102 102
Lines 4416 4421 +5
=============================================
+ Hits 3213 3217 +4
- Misses 1203 1204 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix comment in line 44 and not sure why you need to +
arrays and not just use single array?
Also it would be good to mention this new possibility in docs and/or demos.
Besides that all looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
add definition of plus button, in place of set "plus" => true and add the default label, "plus" => ['icon'=>'plus','class'=>'green']