Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definition of defaults for Field Lookup #670

Merged
merged 3 commits into from
Mar 10, 2019

Conversation

abbadon1334
Copy link
Collaborator

add definition of plus button, in place of set "plus" => true and add the default label, "plus" => ['icon'=>'plus','class'=>'green']

add definition of plus button, in place of set "plus" => true and add the default label, "plus" => ['icon'=>'plus','class'=>'green']
@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #670 into develop will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #670      +/-   ##
=============================================
- Coverage      72.75%   72.69%   -0.07%     
- Complexity      1868     1869       +1     
=============================================
  Files            102      102              
  Lines           4416     4416              
=============================================
- Hits            3213     3210       -3     
- Misses          1203     1206       +3
Impacted Files Coverage Δ Complexity Δ
src/FormField/Lookup.php 76.53% <100%> (ø) 56 <0> (+1) ⬆️
src/TableColumn/Status.php 73.52% <0%> (-8.83%) 12% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4296a25...b133e8a. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #670 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #670      +/-   ##
=============================================
+ Coverage      72.75%   72.76%   +<.01%     
- Complexity      1868     1870       +2     
=============================================
  Files            102      102              
  Lines           4416     4421       +5     
=============================================
+ Hits            3213     3217       +4     
- Misses          1203     1204       +1
Impacted Files Coverage Δ Complexity Δ
src/FormField/Lookup.php 76.79% <100%> (+0.25%) 56 <0> (+1) ⬆️
src/TableColumn/Actions.php 90.9% <0%> (-2.64%) 12% <0%> (+1%)
src/FormField/AutoComplete.php 65.95% <0%> (+0.36%) 33% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4296a25...b79f797. Read the comment docs.

Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix comment in line 44 and not sure why you need to + arrays and not just use single array?
Also it would be good to mention this new possibility in docs and/or demos.

Besides that all looks good.

@DarkSide666 DarkSide666 requested a review from ibelar March 5, 2019 13:54
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@DarkSide666 DarkSide666 merged commit 71a7460 into atk4:develop Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants