Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/jsNotifier Transition #673

Merged
merged 2 commits into from
Mar 5, 2019
Merged

fix/jsNotifier Transition #673

merged 2 commits into from
Mar 5, 2019

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Mar 4, 2019

  • Will also work under Fomantic v2.7.2

@ibelar
fix/jsNotifier Transition
5dd90fb 
- Will work under fomantic v2.7.2
@ibelar ibelar mentioned this pull request Mar 4, 2019
Closed
@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #673 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #673   +/-   ##
==========================================
  Coverage      72.74%   72.74%           
  Complexity      1869     1869           
==========================================
  Files            102      102           
  Lines           4418     4418           
==========================================
  Hits            3214     3214           
  Misses          1204     1204

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3208b13...5dd90fb. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 4, 2019 •
edited
Loading

Codecov Report

Merging #673 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #673   +/-   ##
==========================================
  Coverage      72.74%   72.74%           
  Complexity      1869     1869           
==========================================
  Files            102      102           
  Lines           4418     4418           
==========================================
  Hits            3214     3214           
  Misses          1204     1204

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3208b13...88c3d08. Read the comment docs.

@DarkSide666 DarkSide666 self-requested a review March 5, 2019 13:39
DarkSide666
DarkSide666 approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@DarkSide666 DarkSide666 merged commit a7c3692 into develop Mar 5, 2019
@DarkSide666 DarkSide666 deleted the fix/notify branch March 5, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibelar @DarkSide666