add top and bottom padding to centered layout #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please include screenshots of before/after. |
|
Hi, this is what centered looks like without top&bottom padding/margin. The Heading starts at the very top of the browser window. I resized the window so there's just no scrollbar yet: With some top&bottom padding/margin theres always some space to to the browser window, see screenshot. Again I resized the browser window so there's just no scrollbar yet: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centered layout didnt have any top and bottom padding/margin. On pages that exceeded browsers inner height, that looked quite crappy.
Maybe theres a nicer way using some predefined FUI class?