Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/modal duplication #684

Merged
merged 2 commits into from
Apr 5, 2019
Merged

Fix/modal duplication #684

merged 2 commits into from
Apr 5, 2019

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Apr 5, 2019

Fix #681

Prevent modal from duplicating. Thanks to @pkly

@codecov
Copy link

codecov bot commented Apr 5, 2019 •
edited
Loading

Codecov Report

Merging #684 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #684   +/-   ##
==========================================
  Coverage      72.78%   72.78%           
  Complexity      1921     1921           
==========================================
  Files            105      105           
  Lines           4530     4530           
==========================================
  Hits            3297     3297           
  Misses          1233     1233

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5848836...cdcb0ac. Read the comment docs.

@ibelar ibelar mentioned this pull request Apr 5, 2019
Closed
DarkSide666
DarkSide666 approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeay! Finally this should be fixed!
Thanks @ibelar and @pkly

@DarkSide666 DarkSide666 merged commit e27b207 into develop Apr 5, 2019
@DarkSide666 DarkSide666 deleted the fix/modal-duplication branch April 5, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

@romaninsh romaninsh Awaiting requested review from romaninsh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibelar @DarkSide666