Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation corrections #692

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Documentation corrections #692

merged 3 commits into from
Apr 30, 2019

Conversation

acicovic
Copy link
Collaborator

This is an attempt to fix typos and outdated information such as old links or paths in the documentation and it's a work in progress.

As I read through the documentation I will be correcting any found typos, bad URLs or references, or make minor adjustments such as adding missing links.

Let me know if this work interests you.

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #692 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #692   +/-   ##
==========================================
  Coverage      72.83%   72.83%           
  Complexity      1927     1927           
==========================================
  Files            105      105           
  Lines           4546     4546           
==========================================
  Hits            3311     3311           
  Misses          1235     1235

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd87f3...ac28778. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #692 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #692   +/-   ##
==========================================
  Coverage      72.83%   72.83%           
  Complexity      1927     1927           
==========================================
  Files            105      105           
  Lines           4546     4546           
==========================================
  Hits            3311     3311           
  Misses          1235     1235

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfd87f3...ac28778. Read the comment docs.

@DarkSide666
Copy link
Member

This surely interest us!!! Thanks for your great work here!

Please let us know when you're done with this PR and we will review it and merge in.

@romaninsh romaninsh merged commit e716319 into atk4:develop Apr 30, 2019
@romaninsh
Copy link
Member

thanks, great PR, please keep them coming 💃

@acicovic
Copy link
Collaborator Author

acicovic commented Apr 30, 2019

Hi, awesome :)

Should I submit following commits to this PR or should I open a new one?

Edit: it seems I botched this one so everything will be done in a new PR.

@DarkSide666
Copy link
Member

yeah just create new ones otherwise this one will grow to big and it's hard to follow and review big PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants