Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement Form->addFields() #697

Merged
merged 3 commits into from
May 2, 2019
Merged

implement Form->addFields() #697

merged 3 commits into from
May 2, 2019

Conversation

DarkSide666
Copy link
Member

fix #695

@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #697 into develop will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #697      +/-   ##
=============================================
- Coverage      72.76%   72.73%   -0.04%     
- Complexity      1927     1930       +3     
=============================================
  Files            105      105              
  Lines           4546     4552       +6     
=============================================
+ Hits            3308     3311       +3     
- Misses          1238     1241       +3
Impacted Files Coverage Δ Complexity Δ
src/Form.php 74.82% <0%> (-3.38%) 65 <3> (+3)
src/TableColumn/Status.php 82.35% <0%> (+8.82%) 12% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e716319...0b6aca2. Read the comment docs.

@codecov
Copy link

codecov bot commented May 2, 2019 •
edited
Loading

Codecov Report

Merging #697 into develop will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #697      +/-   ##
=============================================
- Coverage      72.76%   72.73%   -0.04%     
- Complexity      1927     1930       +3     
=============================================
  Files            105      105              
  Lines           4546     4552       +6     
=============================================
+ Hits            3308     3311       +3     
- Misses          1238     1241       +3
Impacted Files Coverage Δ Complexity Δ
src/Form.php 74.82% <0%> (-3.38%) 65 <3> (+3)
src/TableColumn/Status.php 82.35% <0%> (+8.82%) 12% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e716319...db975d8. Read the comment docs.

romaninsh
romaninsh requested changes May 2, 2019
View reviewed changes
Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add mention in the doc

@DarkSide666 DarkSide666 requested a review from romaninsh May 2, 2019 18:29
@romaninsh romaninsh merged commit 5467f53 into develop May 2, 2019
@romaninsh romaninsh deleted the feature/fix-695-addfields branch May 2, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romaninsh romaninsh romaninsh approved these changes

@ibelar ibelar Awaiting requested review from ibelar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

addFields() doesn't work for forms
2 participants
@DarkSide666 @romaninsh